fix: support deno + caching_sha2_password FULL_AUTHENTICATION_PACKET flow #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidorares
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
=======================================
Coverage 90.32% 90.33%
=======================================
Files 71 71
Lines 15727 15730 +3
Branches 1340 1340
=======================================
+ Hits 14206 14209 +3
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hey @sidorares, 🙋🏻♂️
Some common Deno conflicts:
The main challenge is normally handling |
This was referenced Sep 29, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2686
Deno uses default
RSA_PKCS1_PADDINGfor publicEncrypt while in node it'sRSA_PKCS1_OAEP_PADDINGby default. As a resultPERFORM_FULL_AUTHENTICATION_PACKETstep returns password encoded differently from what server expects ( note: mysql versions prior to 8.0.5 might expect RSA_PKCS1_PADDING padding, need to validate that and maybe potentially use based on the server? mysql-net/MySqlConnector#489 )